[GPU] Recognize parameters as valid inputs for compressed weights #32276
+27
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: GPU
mdvoretc-intel
force-pushed
the
param_quant_weight
branch
from
522f237 to
6a6a649
Compare
Contributor
Author
|
build_jenkins |
mdvoretc-intel
force-pushed
the
param_quant_weight
branch
from
6a6a649 to
16d03b4
Compare
mdvoretc-intel
requested review from
CuriousPanCake
and removed request for
a team
Contributor
Author
|
build_jenkins |
mdvoretc-intel
force-pushed
the
param_quant_weight
branch
2 times, most recently
from
b82b902 to
476f80f
Compare
mklimenk
reviewed
Oct 31, 2025
Contributor
mklimenk
left a comment
mklimenk
left a comment
There was a problem hiding this comment.
Two branches of the if (pattern_map.count(weights_const_m)) { condition share a lot of similarities, please consider refactoring it to avoid code duplication
src/plugins/intel_gpu/src/plugin/transformations/convert_fc_to_compressed.cpp
Outdated
Show resolved
Hide resolved
This change enables use of quantized LoRA weights, passed as parameters during execution, to be recognized by the transformaions that produce FullyConnectedCompressed nodes for QGEMM execution.
The test previously expected the transformation to fail due to the use of input2 as a weight. The new logic allows use of parameters as weights, so the test has been adjusted to expect a successful transformation.
mdvoretc-intel
force-pushed
the
param_quant_weight
branch
from
e9e889a to
1c45696
Compare
mklimenk
reviewed
Nov 3, 2025
Contributor
mklimenk
left a comment
mklimenk
left a comment
There was a problem hiding this comment.
Looks much cleaner now, thanks!
Contributor
Author
|
@CuriousPanCake please review. |
github-actions
bot
removed
the
category: transformations
Contributor
Author
|
@CuriousPanCake please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Description of the issue:
At present, the FC_COMPRESSED_WEIGHT_PATTERN macro contains a pattern for dequantization of a constant integer weight. This pattern is used to recognize and fold cases where fused weight dequantization can be used, replacing them with FullyConnectedCompressed nodes. Due to expecting a constant weight input, this pattern fails to recognize quantized LoRA weights, which are provided as parameters:
With the changes in this patch, these weights can be recognized, and the transformations can proceed and produce nodes that would then leverage oneDNN fused QGEMM for execution:
Tickets: